refactor #29
No reviewers
Labels
No labels
bug
core
documentation
duplicate
enhancement
experiment
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Depends on
#28 github-actions
Streigen/echelon
Reference
Streigen/echelon!29
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refactor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR broke down some of the existing large files into smaller ones. This is another PR i wanted to push through before i start the experimentation of slint stack ( Issue #27 ) .
@ -25,2 +8,4 @@mod password_auth;mod registration;pub struct ClientHandler {We should probably rename this and the entire file actually to something that's a bit more accurate I suppose, but that's a minor nitpick, because I like this file being a kind of index file!
@ -0,0 +17,4 @@pub use account::reset_account;pub use auth::{login, logout, oauth_login, oauth_register, register, restore_session};pub use dm::get_dm_rooms;#[allow(deprecated)]👀
tick tock...
@ -91,3 +75,1 @@};Ok(Some((stronghold, client.store(), key_provider, snapshot_path)))let opened = open_store(&key_provider, &snapshot_path, user_id, create_if_missing)?;bless your heart
Everything looks fine, goodbye to user.rs finally...
Just two minor nitpicks above, other than that we should be good to merge and start work on frontend refactor after I make sure actions are fine :D
New commits pushed, approval review dismissed automatically according to repository settings
We can resolve nitpicks later, go ahead and merge