github-actions #28
No reviewers
Labels
No labels
bug
core
documentation
duplicate
enhancement
experiment
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Blocks
#29 refactor
Streigen/echelon
Reference
Streigen/echelon!28
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "github-actions"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR adds a workflow to test commits (via cargo check & svelte check for non-master branches or via tauri build for master branch or pr to master branch).
This should help catch bugs and no more "THIS WORKS ON MY PC!" (hehe @rayyan )
I shouldnt've but I also used this as an opportunity to upgrade packages for keyring and fix the svelte check error that popped up because of
type="text"in the textarea forsrc/routes/chat/+page.svelteThe reasoning behind only doing linux and not the rest is because I will also be experimenting with non-tauri build setups (as discussed in issue #27 ) and it was probably not worth the time spent to make tauri work if we are potentially moving away from tauri anyways.
New commits pushed, approval review dismissed automatically according to repository settings
sorry @human489 but would need another review. the reason for new commit was because keyring was failing for linux, so i switched to using secret service instead (idk why i wasnt doing this earlier)
@ -404,3 +404,3 @@<img src="/attach.svg" alt="attach" class="header-empty-icon" /></button><textarea rows=1 wrap="hard" maxlength=8000 type="text" placeholder="enter a message..." class="chat-input"/><textarea rows=1 wrap="hard" maxlength=8000 placeholder="enter a message..." class="chat-input"></textarea>im smart 😭
Everything looks good! Good work hello flaxee